-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging Handler #36
Logging Handler #36
Conversation
Kudos, SonarCloud Quality Gate passed! |
@@ -16,3 +16,6 @@ | |||
|
|||
# Jetbrains files | |||
.idea/ | |||
|
|||
# kiota | |||
kiota/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious to why this is part of the gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not part of the core-lib and I have come close to git adding it a number of times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah because you're cloning the kiota repo under that structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, this will resolve itself when we close this PR in favor to the one in kiota.
FYI I either use submodules (when no other references options are available) or relative paths (outside of the repo) to avoid this kind of confusion.
@@ -0,0 +1,25 @@ | |||
package msgraphgocore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be part of kiota http and not just msgraph core as it could benefit people building clients for other APIs than MS Graph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean I duplicate the effort in both repos? Or I just move this to Kiota?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just move it
Overview
Adds a logging handler
Demo
Notes
N/A
Testing
Closes #31