Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RedirectHandlerOptions variables to match purpose #515

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Rename RedirectHandlerOptions variables to match purpose #515

merged 1 commit into from
Sep 20, 2021

Conversation

millicentachieng
Copy link
Contributor

Summary

Rename default ShouldRedirect callback function from defaultShouldRetry to defaultShouldRedirect in RedirectHandlerOptions.ts file.

Motivation

For code to make sense.

Types of changes

  • Minor change. Renaming variable.

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nikithauc nikithauc merged commit 4edb1e0 into dev Sep 20, 2021
@baywet baywet deleted the rename-variables branch September 19, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikithauc nikithauc nikithauc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millicentachieng @nikithauc