Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'file description' in LargeFileUploadTask. #533

Conversation

buptliuhs
Copy link
Contributor

@buptliuhs buptliuhs commented Nov 20, 2021

Summary

Support optional file description in LargeFileUploadTask

Motivation

As a user, I want to have the option to add a file description when uploading a file via the LargeFileUploadTask API.

Test plan

N/A.

Closing issues

N/A.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@buptliuhs
Copy link
Contributor Author

buptliuhs commented Nov 20, 2021

No existing unit tests at this level are to be updated. Updated the sample code to reflect the change.

@nikithauc nikithauc merged commit f1fda65 into microsoftgraph:dev Dec 10, 2021
@nikithauc
Copy link
Contributor

@buptliuhs Thanks again for your contribution! I appreciate your feedback and efforts helping to improve the library :)

@nikithauc nikithauc mentioned this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants