Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #854
Before enabling HTTP/2, we check if the feature is supported by curl.
curl_version()["features"]
provides a bitmask comprised of the supported features.We perform a bitwise
&
with theCURL_VERSION_HTTP2
flag to check if it's enabled.Previous implementation had 2 bugs:
CURL_VERSION_HTTP2
flagcurl_version()["features"] & CURL_VERSION_HTTP2 !== 0
first evaluatesCURL_VERSION_HTTP2 !== 0
then performs the bitwise&
always returning1
hence HTTP/2 would always be enabled even if the curl library doesn't enable it.This PR fixes this.
Microsoft Reviewers: Open in CodeFlow