-
Notifications
You must be signed in to change notification settings - Fork 190
Rectifies metadata path information for paths containing Microsoft.Graph prefix in nested segments. #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timayabi2020
merged 8 commits into
dev
from
2453-missing-ms-learn-api-docs-examples-for-powershell-commands
Jan 8, 2024
Merged
Rectifies metadata path information for paths containing Microsoft.Graph prefix in nested segments. #2492
timayabi2020
merged 8 commits into
dev
from
2453-missing-ms-learn-api-docs-examples-for-powershell-commands
Jan 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts containing microsoft.graph prefix
peombwa
suggested changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the recommended pesters tests.
peombwa
reviewed
Dec 15, 2023
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
zengin
approved these changes
Dec 20, 2023
Co-authored-by: Mustafa Zengin <mzengin88@gmail.com>
peombwa
reviewed
Dec 28, 2023
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
…owershell-commands
peombwa
approved these changes
Jan 4, 2024
…owershell-commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2453
Changes proposed in this pull request
/identity/authenticationEventsFlows/{authenticationEventsFlow-id}/microsoft.graph.externalUsersSelfServiceSignUpEventsFlow/onAuthenticationMethodLoadStart/microsoft.graph.onAuthenticationMethodLoadStartExternalUsersSelfServiceSignUp/identityProviders/
has two segments with 'microsoft.graph' prefix. The end result for this example is/identity/authenticationEventsFlows/{authenticationEventsFlow-id}/onAuthenticationMethodLoadStartExternalUsersSelfServiceSignUp/identityProviders
where a whole segment has been truncated. This also affects snippet generation in devx API. The proposed change is to extract the segments and for each segment, remove 'microsoft.graph' prefix and the parenthesis on the last segment.**Current snippet generation result **

Expected snippet generation result
