Update generate upload token to support create additional revision #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process optional parameters like it is done in method "perform_upload", this will allow the introduction of more optional parameter.
…ional_revision" This commit add supporte from parameter introduced in midasplatform/Midas#146
|
lgtm, but I want @jamiesnape to verify. |
| optional_keys = ['checksum', 'create_additional_revision'] | ||
| for key in optional_keys: | ||
| if key in kwargs: | ||
| parameters[key] = kwargs[key] |
There was a problem hiding this comment.
Unless I am mistaken, if checksum=None or create_additional_revision=None, the parameter should not be passed to the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description associated with PR midasplatform/Midas#146 provides the expected details to understand this change.