Fixes bug that if only backlist is supplied incorrectly getting 403 error #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this middleware is used without whitelist and only with backlist is supplied, it incorrectly things that not blacklisted IPs are bad.
F.e.:
Incorrectly thinks that if user comes from IP
127.0.0.1
that with such IP is something wrong.It seems for this case changing IpFirewall default state value helps because in that case IP validation works with rule not
$whited && !$blacked
but with!$blacked || $whited
. And that is what we need for this case.