Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable associative return in JsonPayload #8

Closed
shadowhand opened this issue Nov 8, 2018 · 3 comments
Closed

Cannot disable associative return in JsonPayload #8

shadowhand opened this issue Nov 8, 2018 · 3 comments
Labels

Comments

@shadowhand
Copy link
Member

shadowhand commented Nov 8, 2018

The definition JsonPayload::parse(): array is incompatible with associative(false) flag, which could return any scalar type + array + object.

The return type should be dropped.

@shadowhand shadowhand added the bug label Nov 8, 2018
oscarotero pushed a commit that referenced this issue Nov 8, 2018
@oscarotero
Copy link
Member

Ok, I commited a patch for this. Can you check it?

@shadowhand
Copy link
Member Author

shadowhand commented Nov 8, 2018

Looks good!

@oscarotero
Copy link
Member

Great. I'm going to release a new version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants