Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for team label #76

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Add option for team label #76

merged 3 commits into from
Jun 27, 2024

Conversation

gerardsegarra
Copy link
Contributor

@gerardsegarra gerardsegarra commented Jun 27, 2024

DO-2968

This adds the options for teams to configure the team label.

Extra:
Had to update some dependencies.

@gerardsegarra gerardsegarra requested review from Sturgelose and a team June 27, 2024 10:58
@duhow
Copy link
Contributor

duhow commented Jun 27, 2024

Wouldn't it be better to add extraLabels or similar?
Remember these charts are public, so try to make it generic as much as you can. 🙏🏻

cclavero-mk
cclavero-mk previously approved these changes Jun 27, 2024
Copy link

@cclavero-mk cclavero-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerardsegarra
Copy link
Contributor Author

gerardsegarra commented Jun 27, 2024

@duhow We know this is opinionated, but at the same time, doesn't have any impact with the "if" and it simplifies a lot our side.

@gerardsegarra gerardsegarra requested review from cclavero-mk and a team June 27, 2024 12:04
Copy link

@cclavero-mk cclavero-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerardsegarra gerardsegarra merged commit cc84650 into main Jun 27, 2024
12 checks passed
@gerardsegarra gerardsegarra deleted the add-team-label branch June 27, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants