-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set YUYV as the default frame format. #21
Conversation
where is the YUYV assumption? |
// Attempted to set the YUYV format but encountered an error. | ||
// Note: This error might be a false positive, and the format setting could actually be applied. | ||
// This behavior may be specific to certain camera models/drivers, | ||
// so it's important to carefully check the situation and implement additional verification if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please investigate a bit and at least report a bug before adding a workaround?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
wasi-sensor-discussion/host_wasmtime/src/nokhwa.rs Lines 84 to 90 in dc4a571
is accepting YUYV only so far |
the intention here is to pass frames as they are. |
In my case, it seems MJPG
|
i've heard that mjpeg is somehow commonly used for usb cameras. |
ok. I understand your opinion |
@ayakoakasaka can you try #22? |
Yes. #22 solved my problem. |
This implementation assumes that the default environment is set to YUYV, but that's not the case in my setup. Therefore, I want to set YUYV explicitly as the default. Interestingly, even though this setting returns an error, it applies successfully in behavior.