Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exposure for now #6

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Remove exposure for now #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd9c7a8
wit: remove exposure
yamt Nov 30, 2023
28935f5
guest: remove exposure
yamt Nov 30, 2023
f6c3ac2
regen md
yamt Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guest_rust/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ fn main2() -> Result<()> {
denominator: *ratio.denom() as u32,
});
println!("setting sampling rate to {:?}", value);
sensor.set_property(wasi::sensor::property::PropertyKey::SamplingRate, &value)?;
sensor.set_property(wasi::sensor::property::PropertyKey::SamplingRate, value)?;
// confirm the result
let value = sensor.get_property(wasi::sensor::property::PropertyKey::SamplingRate)?;
println!("sensor sampling rate {:?}", value);
Expand Down
10 changes: 0 additions & 10 deletions sensing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,6 @@
<li><a name="fraction.numerator"><code>numerator</code></a>: <code>u32</code></li>
<li><a name="fraction.denominator"><code>denominator</code></a>: <code>u32</code></li>
</ul>
<h4><a name="exposure"><code>record exposure</code></a></h4>
<h5>Record Fields</h5>
<ul>
<li><a name="exposure.mode"><code>mode</code></a>: <code>string</code><p>Mode of exposure.
</li>
</ul>
<h4><a name="property_key"><code>enum property-key</code></a></h4>
<h5>Enum Cases</h5>
<ul>
Expand All @@ -129,16 +123,12 @@ Eg. frame rate for image sensors.
<li>
<p><a name="property_key.dimension"><a href="#dimension"><code>dimension</code></a></a></p>
</li>
<li>
<p><a name="property_key.exposure"><a href="#exposure"><code>exposure</code></a></a></p>
</li>
</ul>
<h4><a name="property_value"><code>variant property-value</code></a></h4>
<h5>Variant Cases</h5>
<ul>
<li><a name="property_value.fraction"><a href="#fraction"><code>fraction</code></a></a>: <a href="#fraction"><a href="#fraction"><code>fraction</code></a></a></li>
<li><a name="property_value.dimension"><a href="#dimension"><code>dimension</code></a></a>: <a href="#dimension"><a href="#dimension"><code>dimension</code></a></a></li>
<li><a name="property_value.exposure"><a href="#exposure"><code>exposure</code></a></a>: <a href="#exposure"><a href="#exposure"><code>exposure</code></a></a></li>
</ul>
<h2><a name="wasi:sensor_sensor">Import interface wasi:sensor/sensor</a></h2>
<hr />
Expand Down
13 changes: 0 additions & 13 deletions wit/property.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,29 +7,16 @@ interface property {
denominator: u32
}



record exposure {
/// Mode of exposure.
mode: string,
/// More parameters for exposure.
}


enum property-key {
/// The number of samples in a second. (fraction)
/// Eg. frame rate for image sensors.
sampling-rate,

dimension,
exposure,
}

variant property-value {
fraction(fraction),

dimension(dimension),
exposure(exposure),
}
}

Expand Down