Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on gobject-introspection makes cross-compile impossible #303

Closed
stefson opened this issue Mar 17, 2019 · 1 comment · May be fixed by #333
Closed

dependency on gobject-introspection makes cross-compile impossible #303

stefson opened this issue Mar 17, 2019 · 1 comment · May be fixed by #333

Comments

@stefson
Copy link

stefson commented Mar 17, 2019

I'm not sure for what you need introspection support? It makes any attempt of non-native compiling impossible, as gobject-introspection is the most cross-unfriendly package I've ever encountered. And being itself a compiler, overcoming these problems seems not solving any problem.

The midori code itself isn't that demanding to compile, neither is gobject-introspection. But the issue here it's webkit-gtk as a base, which can't be cross-compiled with the gobject-introspection bindings. Midori-0.5 used to work fine without them, now with never versions it seems to be a hard dependency which can't be avoided.

So, do you think you could possibly add a compile switch to disable the need of gobject-introspection? midori is highly efficent on low-memory systems at runtime, but without a cross-compile ability it isn't worth a dev's time to port it.

@kalikiana
Copy link
Member

Introspection is strictly speaking optional so we could allow building without it.

If I understand correctly removing WebKit from the public API would also help the problem at hand, and avoid adding a build option. Although this would require more work.

@kalikiana kalikiana added this to the Sync me baby one more time milestone Mar 19, 2019
kalikiana added a commit to kalikiana/core that referenced this issue Jun 10, 2019
- Expose `Tab` through the new `Viewable` interface
- Omit downloads and context exposure
- Create tabs through a new `add_tab` method
- Expose incognito state through `is_incognito`

Fixes: midori-browser#303
@stefson stefson closed this as completed Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants