Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: task redefine context logger #1213

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Aug 9, 2021

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #1213 (9dc0dd5) into 2.x (a035ccb) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #1213      +/-   ##
==========================================
- Coverage   85.30%   85.29%   -0.02%     
==========================================
  Files         236      236              
  Lines        9174     9181       +7     
  Branches     1740     1741       +1     
==========================================
+ Hits         7826     7831       +5     
- Misses       1276     1278       +2     
  Partials       72       72              
Impacted Files Coverage Δ
packages/web/app/extend/context.js 82.35% <57.14%> (-17.65%) ⬇️
packages/task/src/configuration.ts 90.56% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a035ccb...9dc0dd5. Read the comment docs.

@czy88840616 czy88840616 merged commit f8887c9 into 2.x Aug 9, 2021
@czy88840616 czy88840616 deleted the fix_task_redefine_logger branch August 9, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants