Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): default app logger name error in cluster mode #3455

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

czy88840616
Copy link
Member

在使用 v2 版本的 logger 时,如果使用 egg cluster 模式,midway-web.log 会变成 midway-app.log !!!!!!

@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Nov 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d1e834) 84.59% compared to head (6a7a630) 84.58%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3455      +/-   ##
==========================================
- Coverage   84.59%   84.58%   -0.01%     
==========================================
  Files         478      478              
  Lines       45468    45469       +1     
  Branches     5420     5421       +1     
==========================================
- Hits        38464    38461       -3     
- Misses       6966     6970       +4     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616 czy88840616 merged commit 0fea660 into main Nov 27, 2023
6 checks passed
@czy88840616 czy88840616 deleted the fix_default_logger_config branch November 27, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

2 participants