Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming for io functions #129

Closed
henrymartin1 opened this issue Mar 2, 2021 · 3 comments · Fixed by #179
Closed

Inconsistent naming for io functions #129

henrymartin1 opened this issue Mar 2, 2021 · 3 comments · Fixed by #179
Assignees
Labels

Comments

@henrymartin1
Copy link
Member

At the moment we have:

  • read_positionfixes_csv
  • read_positionfixes_postgis
  • positionfixes_from_gpd
    So I would propose that we rename positionfixes_from_gpd to read_positionfixes_gpd
@svenruf
Copy link
Collaborator

svenruf commented Mar 2, 2021

I originally named it like this, but in a meeting the argument (don't remember from who) was that it isn't actually a reading function, as it does only import/rename the GeoDataFrame. So I changed the name 😄

@henrymartin1
Copy link
Member Author

I think i can remember this 😬. I just tried using it and found it weird that it is named differently...

@henrymartin1
Copy link
Member Author

We agreed on double checking if pandas makes a distinction between reading and loading if it is not external. If there is no distinction, then we can rename the function in read_positionfixes_gpd

@hongyeehh hongyeehh assigned abcnishant007 and unassigned svenruf Mar 17, 2021
henrymartin1 pushed a commit that referenced this issue Mar 19, 2021
Co-authored-by: Nishant Kumar <niskumar@admins-MBP.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants