Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move as_positionfixes.plot method into separate function #506

Closed
bifbof opened this issue Aug 12, 2023 · 0 comments · Fixed by #513
Closed

Move as_positionfixes.plot method into separate function #506

bifbof opened this issue Aug 12, 2023 · 0 comments · Fixed by #513

Comments

@bifbof
Copy link
Collaborator

bifbof commented Aug 12, 2023

with #490 we will subclass GeoDataFrame and thus this method will override the inherited plot function. Access to GeoPanda's plot tools will then only be possible via some direct calls to the GeoDataFrame object.

GeoDataFrame.plot(pfs)(*args, **kwargs)

This behavior is awkward.
I would suggest removing the override method from the class and putting it in a separate function.
This will also removes the need for the cascading plot functionality currently employed, drastically simplifying the function.
Alternatively, you could rename the overriding methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant