ENH: Rework visualization module #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
==========================================
+ Coverage 92.88% 93.05% +0.17%
==========================================
Files 40 34 -6
Lines 2136 2074 -62
Branches 395 388 -7
==========================================
- Hits 1984 1930 -54
+ Misses 133 130 -3
+ Partials 19 14 -5
☔ View full report in Codecov by Sentry. |
hongyeehh
approved these changes
Aug 17, 2023
NinaWie
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one turned out to be bigger than expected.
closes #506
My first motivation was to remove the
positionfixes.plotoverride.But I realized that with all these plot functions cascading calls to each other, it would be much easier to put them into one function that does everything in one go. So I created
ti.plot.With only one function to remember, it is also easier to use trackintel.
The rest of the module was so small that I decided to put them in one file. The resulting file is still quite small at 465 LOC.
So a big part of this PR is just collecting and cleaning things up.
But I know I did a lot in one go, so if you want me to split up some changes or decide to do something else, let me know :)