Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix index error pfs_mean_speed #450

Merged
merged 3 commits into from
Oct 30, 2022
Merged

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Oct 29, 2022

Fixes #449

Apparently the behavior of pd.merge changed after an update.
Other places in the code should not be affected by the pd.merge change.

Also fix error in test where override of geometry column resulted in cast to Series with object type.

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 98.06% // Head: 97.98% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (47ff2b7) compared to base (56176cb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   98.06%   97.98%   -0.09%     
==========================================
  Files          39       32       -7     
  Lines        1858     1783      -75     
  Branches      261      261              
==========================================
- Hits         1822     1747      -75     
  Misses         14       14              
  Partials       22       22              
Impacted Files Coverage Δ
trackintel/model/util.py 100.00% <100.00%> (ø)
trackintel/analysis/__init__.py
trackintel/visualization/__init__.py
trackintel/model/__init__.py
trackintel/geogr/__init__.py
trackintel/__init__.py
trackintel/io/__init__.py
trackintel/preprocessing/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bifbof bifbof requested a review from NinaWie October 29, 2022 09:55
Copy link
Member

@NinaWie NinaWie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests! I left one comment. If you think that case cannot occur, feel free to merge.
I don't get why one of the coverage checks fails. The coverage should be the same, so I think we can ignore it.

trackintel/model/util.py Outdated Show resolved Hide resolved
@NinaWie NinaWie merged commit d3ade20 into mie-lab:master Oct 30, 2022
@bifbof
Copy link
Collaborator Author

bifbof commented Oct 30, 2022

Ready for merge. :)
As for the coverage apparently they don't include the __init__ files anymore → therefor we got a unrelated decrease there.

@bifbof bifbof deleted the bug_index branch October 30, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestPfsMeanSpeedTriplegs.test_triplegs_stable is failing!
2 participants