-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add centroid method for angles #453
Conversation
Codecov ReportBase: 98.06% // Head: 98.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 98.06% 98.08% +0.01%
==========================================
Files 39 39
Lines 1858 1877 +19
Branches 261 263 +2
==========================================
+ Hits 1822 1841 +19
Misses 14 14
Partials 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, thanks for the fix!
I have a small comment for the test and didn't you mention in the error report that the same error applies here. Then we should fix this as well, shouldn't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for the changes!
Fix #437.
Such that centroids can be calculated for angles that pass over the -180, 180 wrapping border.