Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Pre commit #459

Merged
merged 10 commits into from
Feb 10, 2023
Merged

ENH: Pre commit #459

merged 10 commits into from
Feb 10, 2023

Conversation

hongyeehh
Copy link
Member

@hongyeehh hongyeehh commented Feb 9, 2023

Adding pre-commit function to the repo.
Corrected some flake8 errors, therefore a lot of file changes :).

Two functionalities:

  • Enabling pre-commit on your own computer: link
  • This also contains a CI that triggers pre-commit every time a PR and change in file occurs (if it works :)): link

Update: The CI works (see below for commits)! We do not need to worry about black and flake8 formatting anymore :)

closes #458. Additionally suppresses the warnings for PostGIS tests

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 98.18% // Head: 98.18% // No change to project coverage 👍

Coverage data is based on head (949d3b5) compared to base (ebc11aa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          39       39           
  Lines        1877     1877           
  Branches      324      324           
=======================================
  Hits         1843     1843           
  Misses         13       13           
  Partials       21       21           
Impacted Files Coverage Δ
trackintel/geogr/distances.py 94.56% <ø> (ø)
trackintel/io/dataset_reader.py 100.00% <ø> (ø)
trackintel/io/file.py 98.00% <ø> (ø)
trackintel/io/postgis.py 95.60% <ø> (ø)
trackintel/preprocessing/filter.py 100.00% <ø> (ø)
trackintel/preprocessing/positionfixes.py 98.78% <ø> (ø)
trackintel/analysis/tracking_quality.py 100.00% <100.00%> (ø)
trackintel/preprocessing/triplegs.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hongyeehh
Copy link
Member Author

I am merging this to resolve our tests errors and continue working on the conda deployment :)

This PR affects no functions but only includes code format changes.

@hongyeehh hongyeehh merged commit 2b86e39 into mie-lab:master Feb 10, 2023
@hongyeehh hongyeehh deleted the pre-commit branch February 10, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: PostGIS test function failed
1 participant