ENH: remove as_staypoints calls from location_identification #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #476
This PR removes the
as_staypoints
assertions, as the staypoints need to be created initially and there this property is cached.It doesn't really solve the verify problem, but my argument is that we require a
GeoDataFrame (as trackintel staypoints)
and thus can rely that we get the right data shape.In all other places
as_xyz
works as intended, since it is always applied to newly created objects and thus is not yet cached.However, I would like to make this a bit clearer with a proper class hierarchy (which is backwards compatible with our current
as_xyz
approach), but we should discuss that elsewhere.