Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: remove as_staypoints calls from location_identification #478

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Jun 28, 2023

closes #476
This PR removes the as_staypoints assertions, as the staypoints need to be created initially and there this property is cached.
It doesn't really solve the verify problem, but my argument is that we require a GeoDataFrame (as trackintel staypoints) and thus can rely that we get the right data shape.
In all other places as_xyz works as intended, since it is always applied to newly created objects and thus is not yet cached.
However, I would like to make this a bit clearer with a proper class hierarchy (which is backwards compatible with our current as_xyz approach), but we should discuss that elsewhere.

@hongyeehh
Copy link
Member

Thanks. I agree that we shall not check for validity, as we already stated in the documentation. I will merge this PR now.

@hongyeehh hongyeehh merged commit 117fde2 into mie-lab:master Jun 29, 2023
@bifbof bifbof deleted the #476 branch June 29, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obj.as_xyz does not necessarily validate data
2 participants