Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: remove is_datetime64tz_type #522

Merged
merged 1 commit into from
Sep 14, 2023
Merged

ENH: remove is_datetime64tz_type #522

merged 1 commit into from
Sep 14, 2023

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Sep 11, 2023

Replaces all calls of is_datetime64tz_type(obj) with isinstance(obj.dtype, pd.DatetimeTZDtype), because it is deprecated in pandas 2.1.0.
Personally I don't understand why they changed that, but apparently it creates some minor performance increase.

hongyeehh
hongyeehh approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@hongyeehh hongyeehh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. In the original PR, the comment was "it is ambiguous (based on the name)", but I also did not get the reason :)

@hongyeehh hongyeehh merged commit 101baa3 into mie-lab:master Sep 14, 2023
5 checks passed
@bifbof bifbof deleted the pandas_deprecation_datetime branch September 14, 2023 12:00
@bifbof bifbof mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongyeehh hongyeehh hongyeehh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bifbof @hongyeehh