Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: replicate local environment.yml for CI #524

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Sep 12, 2023

I cannot replicate the build error of #520.
Thus I try to change the environment.yml file of the test to see if the error remains.

@bifbof bifbof marked this pull request as draft September 12, 2023 08:10
@bifbof
Copy link
Collaborator Author

bifbof commented Sep 12, 2023

Ok this just worked :D
closes #520

@bifbof bifbof marked this pull request as ready for review September 12, 2023 08:31
@bifbof bifbof linked an issue Sep 12, 2023 that may be closed by this pull request
@hongyeehh
Copy link
Member

Ahh great, so the change is to delete the pandas dependency and rely on its version requirement in geopandas?

@bifbof
Copy link
Collaborator Author

bifbof commented Sep 12, 2023

Ahh great, so the change is to delete the pandas dependency and rely on its version requirement in geopandas?

I think the reason was to move geopandas up in the chain. But to be honest, I neither know what caused this nor what fixed it. I simply copied the environment.yml file from the root.

@hongyeehh
Copy link
Member

Well, anyway, it works. The dependency issue is always a pain :)

@hongyeehh hongyeehh merged commit f550de6 into mie-lab:master Sep 12, 2023
5 checks passed
@bifbof bifbof deleted the fix_bld_error branch September 12, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD: dependency updates causing tests warning and failing
2 participants