CLN: fix deprecation warnings for .idxmax
and .loc[]
#526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
idxmax
two things got deprecated.axis
keyword, this was an easy fixFurther deprecated is
df.loc[idx, "col"] = "string"
; it creates a new column that defaults tofloat64
, that type then gets upcasted toobject
when"string"
gets filled into the dataframe. To avoid this we have to create the column beforehand withdf["col"] = None
.