Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the following problem:
I wanted to import
Positionfixes
into the filedistances.py
to use the class there.But this created a circular import,
positionfixes.py
importsutil.py
which importsdistances.py
which now newly importspositionfixes.py
, and with that python gave up.To fix this I moved all the speed calculations out of
util.py
intodistances.py
, thusutil.py
does not have to importdistances.py
anymore. Further I have reworked thegeogr
module a bit.What is part of this PR:
get_speed_positionfixes
andget_speed_triplegs
togeogr/distances.py
haversine_dist
togeogr/distances.py
and renamed topoint_haversine_dist
to make clear that is still about points, even without theti.geogr.point_distance.haversine_dist
path.ti.geogr
such that we now can useti.geogr.check_gdf
vs.ti.geogr.distances.check_gdf
.