Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Reexport functions from modules #567

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Nov 1, 2023

closes #546
Changed how we export and import functions.
This makes the module paths clearer and additionally all links in the documentation work now as well.

Changed how we export and import functions.
closes mie-lab#546
This makes the module paths clearer and additionally all links in the documentation work.
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a93537) 93.04% compared to head (8bddf52) 93.10%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
+ Coverage   93.04%   93.10%   +0.06%     
==========================================
  Files          33       33              
  Lines        2069     2088      +19     
  Branches      372      373       +1     
==========================================
+ Hits         1925     1944      +19     
  Misses        130      130              
  Partials       14       14              
Files Coverage Δ
trackintel/analysis/location_identification.py 99.09% <ø> (ø)
trackintel/analysis/modal_split.py 100.00% <100.00%> (ø)
trackintel/geogr/__init__.py 100.00% <100.00%> (ø)
trackintel/io/dataset_reader.py 46.90% <ø> (ø)
trackintel/io/file.py 100.00% <ø> (ø)
trackintel/model/locations.py 100.00% <100.00%> (ø)
trackintel/model/positionfixes.py 100.00% <100.00%> (ø)
trackintel/model/staypoints.py 100.00% <100.00%> (ø)
trackintel/model/tours.py 100.00% <100.00%> (ø)
trackintel/model/triplegs.py 100.00% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hongyeehh hongyeehh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed changes. It is great that the links in the docs are now working!

@hongyeehh hongyeehh merged commit f20e334 into mie-lab:master Nov 1, 2023
8 checks passed
@bifbof bifbof deleted the reexport branch November 1, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Re-export functions at module level
2 participants