Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add gpx reader for single user #570

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Nov 8, 2023

That was a lot simpler than I thought.
Currently we assign to all positionfixes user_id = 0.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd83b61) 93.10% compared to head (d6bccca) 93.15%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   93.10%   93.15%   +0.05%     
==========================================
  Files          33       33              
  Lines        2088     2105      +17     
  Branches      373      374       +1     
==========================================
+ Hits         1944     1961      +17     
  Misses        130      130              
  Partials       14       14              
Files Coverage Δ
trackintel/io/__init__.py 100.00% <100.00%> (ø)
trackintel/io/dataset_reader.py 50.41% <100.00%> (+3.51%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bifbof bifbof requested a review from NinaWie November 8, 2023 14:10
Copy link
Member

@NinaWie NinaWie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Have you already tested whether the code can be used to generate staypoints, trips etc, using the test data from Strava and from Henry? We should test that before the workshop

@bifbof
Copy link
Collaborator Author

bifbof commented Nov 8, 2023

It can generate them for Strava (I haven't tried Henry's) and at first glance the staypoints and triplegs seem fine.

@bifbof bifbof merged commit b1adba6 into mie-lab:master Nov 8, 2023
@bifbof bifbof deleted the gpx_reader branch November 8, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants