The UDPConn should be closed when setUDPSocketOptions returned an error

[nirui]

Hi all :D

I'm just reading the source code, and discovered a small potential problem here:

dns/server.go

Line 323 in 67bd57d

if e := setUDPSocketOptions(u); e != nil {

The function setUDPSocketOptions above operates on an already-opened UDPConn, so if an error caused an abort action there, the UDPConn must be closed before doing return e.

I think the code should be:

u := l.(*net.UDPConn)
if e := setUDPSocketOptions(u); e != nil {
    u.Close() // Maybe handle this error too? No?
    return e
}

[tmthrgd]

Yep good catch, feel free to send a PR. There’s no need to handle the error from Close though.