-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyTag for RSAMD5 seems to be wrong #1352
Comments
miekg
added a commit
that referenced
this issue
Mar 31, 2022
Of course the wording was changed (for the better) in an errata: https://www.rfc-editor.org/errata/eid193 We still followed the original RFC4034 text. Note I haven't given this much thought, just changed the 2 into a 3 and ran the test. Fixes: #1352 Signed-off-by: Miek Gieben <miek@miek.nl>
miekg
added a commit
that referenced
this issue
Apr 1, 2022
Of course the wording was changed (for the better) in an errata: https://www.rfc-editor.org/errata/eid193 We still followed the original RFC4034 text. Note I haven't given this much thought, just changed the 2 into a 3 and ran the test. Fixes: #1352 Signed-off-by: Miek Gieben <miek@miek.nl>
aanm
pushed a commit
to cilium/dns
that referenced
this issue
Jul 29, 2022
Of course the wording was changed (for the better) in an errata: https://www.rfc-editor.org/errata/eid193 We still followed the original RFC4034 text. Note I haven't given this much thought, just changed the 2 into a 3 and ran the test. Fixes: miekg#1352 Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have tried to create keys with keytag collision. While doing this I found that this golang dns library seems to compute false keytags for these keys.
I have created the keys with ldns and ldns computes the same keytag for both keys. I have loaded the keys into knot and retrieved with kdig and kdig computes the same keytag for both keys and the same as ldns.
Keytags for other algorithms are correct.
I have written a short test script to show the error.
output on my system is
The text was updated successfully, but these errors were encountered: