-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String() in SVCBAlpn conversion doesn't escape properly #1361
Comments
Here's a simple program demonstrating the issue: |
yes, Stringyfied value should be suitable for inclusion in zone files, so PR welcome. thanks! |
This was referenced Apr 12, 2022
Fixes merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think the idea is that
String()
routines should provide something that is presentation format, suitable for DNS zone files.The
SVCBAlpn
type contains an array of strings. If set via theunpack()
function (or by direct initialization) it can contain non-printable characters, but the correspondingString()
function does not attempt to escape them. Such DNS messages are bogus, of course, but such is DNS. The code in theSVCBLocal
type properly escapes any values.If this is a bug that makes sense to fix, I can submit a PR.
Note that the code in PR #1359 seems to have a similar issue.
The text was updated successfully, but these errors were encountered: