Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVCB dohpath key #1359

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Add SVCB dohpath key #1359

merged 3 commits into from
Apr 12, 2022

Conversation

ainar-g
Copy link
Contributor

@ainar-g ainar-g commented Apr 11, 2022

The parameter is being added in its own IETF draft and also being used in
the IETF draft about Discovery of Designated Resolvers.

Additionally, the mappings of the numeric key values to strings are exported,
under names consistent with the already existing exported mappings, to make it
easier for the clients of the module to validate and print SVCB keys.

Testing was done by sending SVCB queries for the "_dns.resolver.arpa" domain to
OpenDNS's 146.112.41.2 server.

The parameter is being added in [its own IETF draft][1] and also being used in
the [IETF draft about Descovery of Designated Resolvers][2].

Additionally, the mappings of the numeric key values to strings are exported,
under names consistent with the already existing exported mappings, to make it
easier for the clients of the module to validate and print SVCB keys.

Testing was done by sending SVCB queries for the "_dns.resolver.arpa" domain to
OpenDNS's 146.112.41.2 server.

[1]: https://datatracker.ietf.org/doc/html/draft-ietf-add-svcb-dns-02
[2]: https://datatracker.ietf.org/doc/html/draft-ietf-add-ddr-06.html
svcb.go Outdated Show resolved Hide resolved
svcb.go Show resolved Hide resolved
svcb.go Outdated Show resolved Hide resolved
svcb.go Outdated Show resolved Hide resolved
svcb.go Outdated Show resolved Hide resolved
@ainar-g
Copy link
Contributor Author

ainar-g commented Apr 12, 2022

@miekg, thanks for the review, ptal!

@ainar-g ainar-g requested a review from miekg April 12, 2022 14:44
svcb.go Show resolved Hide resolved
svcb.go Outdated Show resolved Hide resolved
@ainar-g ainar-g requested a review from miekg April 12, 2022 15:37
@miekg miekg merged commit 08c2616 into miekg:master Apr 12, 2022
ainar-g added a commit to ainar-g/dns that referenced this pull request Apr 12, 2022
The mappings of the numeric SVCB key values to strings are exported, under names
consistent with the already existing exported mappings, to make it easier for
the clients of the module to validate and print SVCB keys.

Split off from miekg#1359.
@ainar-g ainar-g mentioned this pull request Apr 12, 2022
@tmthrgd
Copy link
Collaborator

tmthrgd commented Apr 13, 2022

I have to say I really dislike that we’re pulling in so many draft standards for SVCB. We’ve already seen them change in ways bordering on backwards-incompatible. I’d personally rather wait for these to be actually published as RFCs.

@tmthrgd
Copy link
Collaborator

tmthrgd commented Apr 13, 2022

I should clarify, I don’t object to implementing drafts where they can be kept as internal implementation details, but I do object when they become part of our public API.

@miekg
Copy link
Owner

miekg commented Apr 13, 2022 via email

@ainar-g
Copy link
Contributor Author

ainar-g commented Apr 13, 2022

@miekg, the Go standard library has a few spots where it explicitly says that something is experimental and is likely to change in the future. For example, package syscall/js. I could send a PR where I go through all exported SVCB identifiers and add a warning regarding the draft status of this functionality.

@miekg
Copy link
Owner

miekg commented Apr 13, 2022 via email

aanm pushed a commit to cilium/dns that referenced this pull request Jul 29, 2022
* Add SVCB dohpath key

The parameter is being added in [its own IETF draft][1] and also being used in
the [IETF draft about Descovery of Designated Resolvers][2].

Additionally, the mappings of the numeric key values to strings are exported,
under names consistent with the already existing exported mappings, to make it
easier for the clients of the module to validate and print SVCB keys.

Testing was done by sending SVCB queries for the "_dns.resolver.arpa" domain to
OpenDNS's 146.112.41.2 server.

[1]: https://datatracker.ietf.org/doc/html/draft-ietf-add-svcb-dns-02
[2]: https://datatracker.ietf.org/doc/html/draft-ietf-add-ddr-06.html

* Fix template length, docs; reverse some changes

* Remove incorrect validations; improve docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants