Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuzzer] Avoid fuzzing parser with line that contains "$INCLUDE" #1026

Merged
merged 1 commit into from
Oct 10, 2019
Merged

[fuzzer] Avoid fuzzing parser with line that contains "$INCLUDE" #1026

merged 1 commit into from
Oct 10, 2019

Conversation

chantra
Copy link
Contributor

@chantra chantra commented Oct 9, 2019

Fixes #1025

GO111MODULE=off make -f Makefile.fuzz build
go-fuzz -bin=dns-fuzz.zip -workdir=fuzz -func Fuzz
GO111MODULE=off make -f Makefile.fuzz build-rr
go-fuzz -bin=dns-fuzz.zip -workdir=fuzz -func FuzzNewRR

@chantra
[fuzzer] Avoid fuzzing parser with line that contains "$INCLUDE"
ba5b9ea 
Fixes miekg#1025

```
GO111MODULE=off make -f Makefile.fuzz build
go-fuzz -bin=dns-fuzz.zip -workdir=fuzz -func Fuzz
GO111MODULE=off make -f Makefile.fuzz build-rr
go-fuzz -bin=dns-fuzz.zip -workdir=fuzz -func FuzzNewRR
```
@codecov-io
Copy link

codecov-io commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #1026 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   54.79%   54.83%   +0.04%     
==========================================
  Files          41       41              
  Lines        9856     9856              
==========================================
+ Hits         5401     5405       +4     
+ Misses       3432     3429       -3     
+ Partials     1023     1022       -1
Impacted Files Coverage Δ
msg.go 77.5% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997f079...ba5b9ea. Read the comment docs.

@miekg miekg merged commit 40eab7a into miekg:master Oct 10, 2019
@chantra chantra deleted the fuzzer_exclude_include branch October 10, 2019 06:48
aanm pushed a commit to cilium/dns that referenced this pull request Jul 29, 2022
@chantra @aanm
[fuzzer] Avoid fuzzing parser with line that contains "$INCLUDE" (mie…
70dd9ec 
…kg#1026)

Fixes miekg#1025

```
GO111MODULE=off make -f Makefile.fuzz build
go-fuzz -bin=dns-fuzz.zip -workdir=fuzz -func Fuzz
GO111MODULE=off make -f Makefile.fuzz build-rr
go-fuzz -bin=dns-fuzz.zip -workdir=fuzz -func FuzzNewRR
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miekg miekg miekg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fuzzer] $INCLUDE hanging indefinitely
3 participants
@chantra @codecov-io @miekg