Remove RSAMD5 support from (*RRSIG).Verify #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK, the only way to get an RSAMD5 DNSKEY was to manually construct one. This is ancient, just get rid of it. The only remaining usage of md5 is in tsig.go. Hopefully that might be removable as well.
Codecov Report
@@ Coverage Diff @@
## master #1185 +/- ##
=======================================
Coverage 55.16% 55.16%
=======================================
Files 42 42
Lines 9586 9586
=======================================
Hits 5288 5288
Misses 3274 3274
Partials 1024 1024
Continue to review full report at Codecov.
|
miekg
approved these changes
Oct 24, 2020
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
AFAIK, the only way to get an RSAMD5 DNSKEY was to manually construct one. This is ancient, just get rid of it. The only remaining usage of md5 is in tsig.go. Hopefully that might be removable as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK, the only way to get an RSAMD5 DNSKEY was to manually construct one. This is ancient, just get rid of it.
The only remaining usage of md5 is in tsig.go. Hopefully that might be removable as well.