Fix copy() in SVCBIPv4Hint and SVCBIPv6Hint #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the current implementation is that it is not a real deep copy, it points to the same base arrays behind the slices. This was causing some issues in real-life application.
tmthrgd
requested changes
Apr 22, 2021
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
* Fix copy() in SVCBIPv4Hint and SVCBIPv6Hint The problem with the current implementation is that it is not a real deep copy, it points to the same base arrays behind the slices. This was causing some issues in real-life application. * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the current implementation is that it is not a real deep copy,
it points to the same base arrays behind the slices. This was causing some
issues in real-life application.