Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle packing of empty RDATA correctly for EDNS0_EXPIRE (Resolves #1292) #1293

Merged
merged 5 commits into from
Mar 12, 2022
Merged

Handle packing of empty RDATA correctly for EDNS0_EXPIRE (Resolves #1292) #1293

merged 5 commits into from
Mar 12, 2022

Commits on Sep 13, 2021

  1. Change EDNS_EXPIRE field to support zero length option data (Resolves m… 

    …iekg#1292)

As per [RFC7134](https://datatracker.ietf.org/doc/html/rfc7314#section-2) the Expire
Option in queries should be zero-length. In the current implementation the field is
uint32 which always instatiates 4bytes for that field when packing to wire format.
For that reason we change the field to []uint8 so it can support 0-length and 4-byte
length option data.
    @dmavrommatis
    dmavrommatis committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    8161c7d View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. addressed comments

    @dmavrommatis
    dmavrommatis committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    6f14f3c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. addressed comments

    @dmavrommatis
    dmavrommatis committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    ba45878 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. make change backwards compatible

    @dmavrommatis
    dmavrommatis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    dc39a2c View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. add comment for Empty field

    @dmavrommatis
    dmavrommatis committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    37bd514 View commit details
    Browse the repository at this point in the history