Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AMTRELAY and IPSECKEY RR types #1402

Merged
merged 5 commits into from
Feb 26, 2023
Merged

Add AMTRELAY and IPSECKEY RR types #1402

merged 5 commits into from
Feb 26, 2023

Conversation

monoidic
Copy link
Contributor

This PR adds the AMTRELAY and IPSECKEY RR types to this library, and bumps dependencies because go generate appears to be broken otherwise.

@miekg
Copy link
Owner

miekg commented Nov 19, 2022

looks good in general, but I've got a bunch of nits and questions.

You can also update the README and add RFC 8777 and 4025

miekg
miekg reviewed Nov 19, 2022
View reviewed changes
go.mod Show resolved Hide resolved
miekg
miekg reviewed Nov 19, 2022
View reviewed changes
types.go Outdated Show resolved Hide resolved
miekg
miekg reviewed Nov 19, 2022
View reviewed changes
types.go Outdated Show resolved Hide resolved
miekg
miekg reviewed Nov 19, 2022
View reviewed changes
types.go Outdated Show resolved Hide resolved
miekg
miekg reviewed Nov 19, 2022
View reviewed changes
types.go Outdated Show resolved Hide resolved
miekg
miekg reviewed Nov 19, 2022
View reviewed changes
types.go Outdated Show resolved Hide resolved
miekg
miekg reviewed Nov 19, 2022
View reviewed changes
types.go Show resolved Hide resolved
miekg
miekg reviewed Nov 19, 2022
View reviewed changes
scan_rr.go Outdated Show resolved Hide resolved
tmthrgd
tmthrgd requested changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@tmthrgd tmthrgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine with me, just a handful of nits to address.

scan_rr.go Outdated Show resolved Hide resolved
scan_rr.go Outdated Show resolved Hide resolved
scan_rr.go Outdated Show resolved Hide resolved
scan_rr.go Outdated Show resolved Hide resolved
scan_rr.go Outdated Show resolved Hide resolved
scan_rr.go Outdated Show resolved Hide resolved
scan_rr.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
@monoidic monoidic requested a review from tmthrgd January 18, 2023 10:58
@miekg
Copy link
Owner

miekg commented Feb 2, 2023

@tmthrgd you happy with this now? If so, you (or I) can click 'squash and merge'

@tmthrgd
Copy link
Collaborator

tmthrgd commented Feb 15, 2023

@miekg There's still one un-resolved review comment about DiscoveryOptional. I think that either needs to be marked as resolved or changed first.

tmthrgd
tmthrgd reviewed Feb 15, 2023
View reviewed changes
scan_rr.go Outdated Show resolved Hide resolved
@monoidic monoidic force-pushed the amtrelay-ipseckey branch 3 times, most recently from dcb1d8f to ce7b45f Compare February 15, 2023 13:39
@monoidic monoidic requested a review from tmthrgd February 15, 2023 15:04
tmthrgd
tmthrgd approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@tmthrgd tmthrgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miekg miekg merged commit 21e21a3 into miekg:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miekg miekg miekg left review comments

@tmthrgd tmthrgd tmthrgd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monoidic @miekg @tmthrgd