Set public key from private key in DNSKEY instead of copying it from DNSKEY to private key #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baest
force-pushed
the
set_public_key_from_private_key
branch
from
4c2c49c
to
afda3af
Compare
baest
force-pushed
the
set_public_key_from_private_key
branch
from
afda3af
to
b680beb
Compare
…DNSKEY to private key Previously when loading a PrivateKey into a DNSKEY we would return the PrivateKey with the PublicKey set from the DNSKEY struct. Now that behaviour is flipped and the PublicKey is taken from the PrivateKey and set in the DNSKEY. It will now fail if the algorithm or PublicKey in the DNSKEY doesn't match what is loaded in the input file
baest
force-pushed
the
set_public_key_from_private_key
branch
from
b680beb
to
d9e2afe
Compare
miekg
reviewed
Jun 13, 2024
| @@ -48,27 +48,29 @@ const ( | |||
|
|
|||
| // Errors defined in this package. | |||
| var ( | |||
| ErrAlg error = &Error{err: "bad algorithm"} // ErrAlg indicates an error with the (DNSSEC) algorithm. | |||
There was a problem hiding this comment.
I added a new entry and my editor reformatted the code to align better. I thought it an ok change so I kept it, but I can take this out if needed.
|
what motivates this change? |
I have private keys stored in a database and I need to load those, get the public key from it and also use that to create the DS. The previous version took the public key from the DNSKEY object and then copied it into the private key. To me it makes more sense to just keep the public key stored inside the private key (and it also serves my needs to be fair). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when loading a PrivateKey into a DNSKEY we would return the PrivateKey with the PublicKey set from the DNSKEY struct. Now that behaviour is flipped and the PublicKey is taken from the PrivateKey and set in the DNSKEY.