fix LDFLAGS for darwin to avoid go1.9.4 error

[dmitris]

PR fixes #63 for Darwin
@miekg

[miekg]

Can you update all Unixes?

[dmitris]

I suggest to start with merging this as is, for the sake of the Darwin, and then figure out what to do for Unix (not sure about Windows).

[justincormack]

Ah, was just about to open a PR for the same thing!

[miekg]

diff --git a/pkcs11.go b/pkcs11.go
index 7abc9a1..b6fdef3 100644
--- a/pkcs11.go
+++ b/pkcs11.go
@@ -13,7 +13,7 @@ package pkcs11
 /*
 #cgo windows CFLAGS: -DREPACK_STRUCTURES
 #cgo windows LDFLAGS: -Wl,--no-as-needed -lltdl
-#cgo linux LDFLAGS: -Wl,--no-as-needed -lltdl -ldl
+#cgo linux LDFLAGS: -lltdl -ldl
 #cgo darwin CFLAGS: -I/usr/local/share/libtool
 #cgo darwin LDFLAGS: -lltdl -L/usr/local/lib/
 #cgo openbsd CFLAGS: -I/usr/local/include/

makes it compile on my Linux debian box.

[justincormack]

Linux and Windows need fixes too, I can do a PR for those.

[miekg]

please do @justincormack

[ruiadrmartins]

Just to add, it also happens on go 1.8.7 on Linux at least

[andlabs]

I'd personally wait to see if the Go team whitelists -Wl,-no-as-needed.