-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined export option for Separate files + merged #480
Comments
Sure. This could be an option under settings |
@mifi thanks, ideally both, in the "auto merge" settings as well as the button on the top (between output format and keyframe/normakl cut) so one can just click the buttons to cycle between 1) Merge cuts 2) Separate files 3) Merge & Separate files. Just to clarify, would it be technically possible to have a preview playback mode of just the segments how the merged video will look like? As this could also be useful and perhaps eliminate otherwise that step to export and review separate files before merging them. |
technically possible yes #253 |
have implelemnted a config option to keep the segments upon merge |
@mifi Is that already in the current windows version? I couldn't see it in the settings and neither the export dialogue. Also the word "single" to me is not very clear/obvious, referring to a selected Segment from the timeline. |
It's under settings. "Auto delete segment files after merge?" |
Sorry but I didn't find that in the current 3.27.0 version and #480 is not listed, are you sure it's in that version already or still to be released? |
Oops! I had not yet released that. Try with 3.29. building now! |
@mifi Merging takes ages now for some reason on 3.29.1, on a 1hr video takes almost 3minutes while on v3.23.8 only less than 5 seconds., despite in both using the same project with merge cuts & normal cut mode (auto delete). |
How many segments are you exporting (and how long are they)? |
And are you creating chapters or custom metadata? |
Ok I can reproduce the issue. In 3.29.1 I changed the default to now preserve metadata in files when merging. It seems like this is making ffmpeg a LOT slower |
I have made preerve metadata on merge default to FALSE, and added an option to enable it |
#480 (comment) Also make it more clear that chapters from meta is slow
Does that mean in previous versions this was different configured so that you needed to match that setting again in 3.29.1 or why only now did that impact occur now / requires that optional setting? I repeated the same project, just different versions. |
In previous versions of losslesscut (eg. 3.23.8), metadata would not get preserved when doing a merge. in 3.29.1 I defaulted to preserving metadata during merge, as that made sense to me, but I didn't realize that it would slow down so much. So in the next version I added an option to preserve metadtata (default false) |
Gotcha, would that alone really be so time/processor intensive to make such a big difference? |
I have no idea why, but it is much slower (I tested with/without it) |
hence I'm asking as it sounds like we might be missing something here that causes a huge delay, might not be just the fact you enabled preserving meta data. If this can be fixed that would be brilliant to avoid unnecessary disabling it just for speedy export sake. |
created an issue for that |
@mifi just to follow up re changes:
|
|
Thanks @mifi 1 ) I suspect that previously many people where generally happy/accepted that cuts are not 100% accurate and that there isn't yet a built in way to preview where the cut will be in the export, and thus don't go through the effort of checking often the individual segments in the file explorer before using them individual or using a merged file (except likely people with generell editing experience would do this to achieve best results). 2 ) re output format, would have thought that LC automatically uses the same format as input by default, thus not require changing it every time when different formats are imported, expecting the preference usually to be to stay in the same format just as staying lossless as much as possible would be the preference. I would expect for regular editing of most people more likely to be using the same type of files anyway (also most content probably is h264 MP4 for videos, which is why i wasn't suprised to see MP4 initially selected). 2.2) But if matching output format with input format is not implemented I would highly suggest this as a feature request. Perhaps this would then also make a point for possibly removing the button, but then again don't think for an advanced view it should bother one too much, as there is always the simple view mode for a total clean simple UI :) 2.3) There is the thought of course perhaps to have a configurable UI in the long term future :D (nice to have long term enhancement) 2.4) But I still challenge the case that usage/switching of merging Vs splitting to be not that infrequent, after all I think that's why we initially must have had this choice as a button in the first place. Yes we can still set it in the export dialogue but if this is the only thing being changed it would make a case for a preference to disable the export dialogue and regularly switching merge/split/merge+split and only enable back the export dialogue for exceptions. Recent use case: (Also started getting messy with selecting right files in the file explorer due to file creation date matching source file creation date instead of the export creation dates - see #611) Sorry for the long reply, there is a lot in it but hope it makes sense and wonder if the suggested workflow would be beneficial and perhaps become more popular in usage. |
Yes lc tries to detect the input format by default. I think we could hide the output format button from the main ui in simple mode. We cannotcompletely remove the out format button, because sometimes people might simply want to convert an mkv video into an mp4 for playback on iPhone etc. |
You can probably delete the setting for keeping segments as the drop-down selection makes it redundant. I'm happy seeing the out format button in the advanced view but with that can you please bring back the drop-down for merge/split/merge+split please in advanced UI? 😊 |
Feature request: Combined profile to eliminate changing between merged and separate files export.
Love lossless-cut, it's exactly what I was looking for an easy to use app to give to people so they can not just trim but cut out parts of the video, without loosing quality or take ages to render. 👍
Given that keyframe cut is probably preferred over normal cut to eliminate the risk of empty portions, and since there is probably no way to simulate a playback of that without exporting it first, I find that exporting first as separate files allows one to check the begnning/ending of each segments and then when happy export as merged.
Therefore when hopefully cut points are well selected in most situations, it could speed up the workflow by having an combined export option to get both a merged file with also separate files, to allow for checking segments and when happy just manually delete them without having to export as merged there after and keep changing export options back and forth.
The text was updated successfully, but these errors were encountered: