-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Cannot find module '@actions/core' #5
Comments
I have the same issue. |
I hate 'me too' posts, but... me too. Thanks for the time and effort to put this together in the first place! |
@vanosg I got around the issue by just doing this (you'll have to put proper path to your .bats file of course):
|
Replace `mig4/setup-bats` with manual `npm install` due to the following bug: mig4/setup-bats#5
Same problem here. Running |
Apologies for this slipping by unnoticed for a while. So this is because I followed GitHub Actions documentation which, at least at that time, suggested discouraging users from using master branch and in fact suggested not to include built code in master branch therefore preventing its use entirely. TL;DR should be OK if you use the release branch: But I've just noticed that in the marketplace it shows the README from master which shows a bad example. So I recon at the least I should update docs, but I'll check with actions docs to see if the recommendations have changed. |
Right so the upstream action template has changed and now uses ncc and now does include build artifacts in master. I'll update to follow that template. The recommendation to only use releases stands, so |
Since marketplace shows README from the master branch, change it to suggest using the latest release. Using master directly is not supported and in fact doesn't work in current form. Also, Actions are now out of beta so remove the warning. Towards #5
This is fixed now, I updated the README in the master branch so instructions shown on marketplace page recommend using Holla if there's still issues with this, and many thanks for reporting @Biont ❤️ |
Granted, this is the first time I'm trying out Github Actions and I could well be doing things wrong entirely. But while I could use and run a shellcheck action from another repo successfully, this action here fails with the above error.
Full log output here:
Please let me know if I can provide more information to help solve this. And thanks for creating this action.
The text was updated successfully, but these errors were encountered: