Feature/improve docker compose #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The docker setup was made at the very beginning of the repository lifetime and it needs to be updated.
With this new setup, the docker images should be a lot smaller and docker-compose is easier to understand.
Description
We have enabled production mode in the Dockerfiles, removed unnecessary variable
MYFOLDERand loaded .env files directly from the subfolders. Docker images should weight less than half as before and we also changed the names of the images and containers, before it was fixed and we could not now the folder it was running from.We have also added a local network which should improve security and make it easier for other containers to join the internal network and connect to the containers.