Merge pull request #1680 from mightyiam/no-import-type-side-effects

feat!: @typescript-eslint/no-import-type-side-effects
mightyiam · Jul 23, 2024 · a50bd6a · a50bd6a
2 parents b228e09 + 9970ecf
commit a50bd6a
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -175,6 +175,7 @@ const rules = {
   '@typescript-eslint/no-floating-promises': ['error'],
   '@typescript-eslint/no-for-in-array': ['error'],
   '@typescript-eslint/no-implied-eval': ['error'],
+  '@typescript-eslint/no-import-type-side-effects': ['error'],
   '@typescript-eslint/no-invalid-void-type': ['error'],
   '@typescript-eslint/no-loss-of-precision': ['error'],
   '@typescript-eslint/no-misused-new': ['error'],

diff --git a/src/plugins.d.ts b/src/plugins.d.ts
@@ -1,15 +1,15 @@
 declare module 'eslint-plugin-n' {
-  import { type TSESLint } from '@typescript-eslint/utils'
+  import type { TSESLint } from '@typescript-eslint/utils'
   const plugin: TSESLint.Linter.Plugin
   export = plugin
 }
 declare module 'eslint-plugin-import' {
-  import { type TSESLint } from '@typescript-eslint/utils'
+  import type { TSESLint } from '@typescript-eslint/utils'
   const plugin: TSESLint.Linter.Plugin
   export = plugin
 }
 declare module 'eslint-plugin-promise' {
-  import { type TSESLint } from '@typescript-eslint/utils'
+  import type { TSESLint } from '@typescript-eslint/utils'
   const plugin: TSESLint.Linter.Plugin
   export = plugin
 }
diff --git a/src/test/_expected-exported-value.ts b/src/test/_expected-exported-value.ts
@@ -1,4 +1,4 @@
-import { type TSESLint } from '@typescript-eslint/utils'
+import type { TSESLint } from '@typescript-eslint/utils'
 import { parser, plugin as tseslintPlugin } from 'typescript-eslint'
 import * as importPlugin from 'eslint-plugin-import'
 import * as nPlugin from 'eslint-plugin-n'
@@ -334,6 +334,7 @@ export const expectedExportedValue: TSESLint.FlatConfig.Config = {
     '@typescript-eslint/no-floating-promises': ['error'],
     '@typescript-eslint/no-for-in-array': ['error'],
     '@typescript-eslint/no-implied-eval': ['error'],
+    '@typescript-eslint/no-import-type-side-effects': ['error'],
     '@typescript-eslint/no-invalid-void-type': ['error'],
     '@typescript-eslint/no-loss-of-precision': ['error'],
     '@typescript-eslint/no-misused-new': ['error'],

diff --git a/src/test/_rules_to_consider.ts b/src/test/_rules_to_consider.ts
@@ -1,6 +1,5 @@
 export const rulesToConsider = [
   '@typescript-eslint/no-empty-object-type',
-  '@typescript-eslint/no-import-type-side-effects',
   '@typescript-eslint/no-inferrable-types',
   '@typescript-eslint/no-invalid-this',
   '@typescript-eslint/no-loop-func',

diff --git a/src/test/_util.ts b/src/test/_util.ts
@@ -2,7 +2,7 @@ import exported from '..'
 import { plugin as tseslintPlugin } from 'typescript-eslint'
 import { TSESLint } from '@typescript-eslint/utils'
 import semver from 'semver'
-import { type PackageJson } from 'type-fest'
+import type { PackageJson } from 'type-fest'
 
 interface PkgDetails {
   pkgPath: string