Merge pull request #1690 from mightyiam/new-rule-no-empty-object-type

feat!: @typescript-eslint/no-empty-object-type
mightyiam · Jul 27, 2024 · a519540 · a519540
2 parents 56bcfa4 + 3746639
commit a519540
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/src/_intentionally-unused-rules.ts b/src/_intentionally-unused-rules.ts
@@ -25,4 +25,7 @@ export const intentionallyUnusedRules: string[] = [
 
   // Covered by strict TypeScript
   '@typescript-eslint/no-invalid-this',
+
+  // Covered by `@typescript-eslint/no-empty-object-type`
+  '@typescript-eslint/no-empty-interface',
 ]
diff --git a/src/index.ts b/src/index.ts
@@ -159,10 +159,6 @@ const rules = {
       allow: [],
     },
   ],
-  '@typescript-eslint/no-empty-interface': [
-    'error',
-    { allowSingleExtends: true },
-  ],
   '@typescript-eslint/no-explicit-any': [
     'error',
     { fixToUnknown: false, ignoreRestArgs: false },
@@ -172,6 +168,10 @@ const rules = {
     'error',
     { allowWithDecorator: true },
   ],
+  '@typescript-eslint/no-empty-object-type': [
+    'error',
+    { allowInterfaces: 'with-single-extends', allowObjectTypes: 'never' },
+  ],
   '@typescript-eslint/no-floating-promises': ['error'],
   '@typescript-eslint/no-for-in-array': ['error'],
   '@typescript-eslint/no-implied-eval': ['error'],

diff --git a/src/test/_expected-exported-value.ts b/src/test/_expected-exported-value.ts
@@ -319,10 +319,6 @@ export const expectedExportedValue: TSESLint.FlatConfig.Config = {
         allow: [],
       },
     ],
-    '@typescript-eslint/no-empty-interface': [
-      'error',
-      { allowSingleExtends: true },
-    ],
     '@typescript-eslint/no-explicit-any': [
       'error',
       { fixToUnknown: false, ignoreRestArgs: false },
@@ -332,6 +328,10 @@ export const expectedExportedValue: TSESLint.FlatConfig.Config = {
       'error',
       { allowWithDecorator: true },
     ],
+    '@typescript-eslint/no-empty-object-type': [
+      'error',
+      { allowInterfaces: 'with-single-extends', allowObjectTypes: 'never' },
+    ],
     '@typescript-eslint/no-floating-promises': ['error'],
     '@typescript-eslint/no-for-in-array': ['error'],
     '@typescript-eslint/no-implied-eval': ['error'],

diff --git a/src/test/_rules_to_consider.ts b/src/test/_rules_to_consider.ts
@@ -1,5 +1,4 @@
 export const rulesToConsider = [
-  '@typescript-eslint/no-empty-object-type',
   '@typescript-eslint/no-inferrable-types',
   '@typescript-eslint/no-magic-numbers',
   '@typescript-eslint/no-meaningless-void-operator',