feat!: @typescript-eslint/no-unnecessary-condition

mightyiam · Sep 21, 2024 · edc29da · edc29da
1 parent 8b68bf3
commit edc29da
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -168,6 +168,12 @@ const rules = {
   ],
   '@typescript-eslint/no-this-alias': ['error', { allowDestructuring: true }],
   '@typescript-eslint/no-unnecessary-boolean-literal-compare': ['error'],
+  '@typescript-eslint/no-unnecessary-condition': [
+    'error',
+    {
+      allowConstantLoopConditions: true,
+    },
+  ],
   '@typescript-eslint/no-unnecessary-type-assertion': ['error'],
   '@typescript-eslint/no-unnecessary-type-constraint': ['error'],
   '@typescript-eslint/no-unsafe-argument': ['error'],

diff --git a/src/test/_expected-exported-value.ts b/src/test/_expected-exported-value.ts
@@ -329,6 +329,12 @@ export const expectedExportedValue: TSESLint.FlatConfig.Config = {
       'error',
       { allow: [], allowAsImport: false },
     ],
+    '@typescript-eslint/no-unnecessary-condition': [
+      'error',
+      {
+        allowConstantLoopConditions: true,
+      },
+    ],
     '@typescript-eslint/no-unnecessary-type-assertion': ['error'],
     '@typescript-eslint/no-unnecessary-type-constraint': ['error'],
     '@typescript-eslint/no-unnecessary-boolean-literal-compare': ['error'],

diff --git a/src/test/_rules_to_consider.ts b/src/test/_rules_to_consider.ts
@@ -1,5 +1,4 @@
 export const rulesToConsider = [
-  '@typescript-eslint/no-unnecessary-condition',
   '@typescript-eslint/no-unnecessary-parameter-property-assignment',
   '@typescript-eslint/no-unnecessary-qualifier',
   '@typescript-eslint/no-unnecessary-template-expression',

diff --git a/src/test/rules.ts b/src/test/rules.ts
@@ -9,10 +9,6 @@ import { TSESLint } from '@typescript-eslint/utils'
 import { intentionallyUnusedRules } from '../_intentionally-unused-rules'
 import { rulesToConsider } from './_rules_to_consider'
 
-if (pluginN === undefined) throw new Error()
-if (pluginImport === undefined) throw new Error()
-if (pluginPromise === undefined) throw new Error()
-
 const eslintRules = new TSESLint.Linter().getRules()
 
 if (pluginN.rules === undefined) throw new Error()
@@ -105,7 +101,6 @@ test('no deprecated rules', (t) => {
 test('JS equivalent rules are off', async (t) => {
   if (pluginTseslint.rules === undefined) throw new Error()
   const ourRules_: TSESLint.FlatConfig.Rules = ourRules
-  if (ourRules_ === undefined) throw new Error()
 
   const jsEquivalentRulesThatAreOn = equivalents.filter((ruleName) => {
     const baseRuleConfig = ourRules_[ruleName]