Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import values for equivalent rules from Standard #170

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

mightyiam
Copy link
Owner

Fixes #160.

@mightyiam mightyiam force-pushed the import-equiv-values branch 2 times, most recently from 3b78ee9 to 941506b Compare November 12, 2019 16:14
Copy link
Owner Author

@mightyiam mightyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Would like to see that this is understandable to others before merging.

'no-use-before-define': 'off',
'no-useless-constructor': 'off',
quotes: 'off',
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block is replaced by mostly (except for one) programmatic generation of the turning off of the rules.

'@typescript-eslint/no-use-before-define': ['error', { functions: false, classes: false, variables: false, typedefs: false }],
'@typescript-eslint/no-useless-constructor': 'error',
'@typescript-eslint/quotes': ['error', 'single', { avoidEscape: true, allowTemplateLiterals: false }],
'@typescript-eslint/require-await': 'error',
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this block is programmatically obtained from the real values from Standard.

@mightyiam
Copy link
Owner Author

By the way, working on this PR is how I discovered 3 bugs: #168, #165 and #164.

@mightyiam mightyiam merged commit 710fba5 into master Nov 15, 2019
@mightyiam mightyiam deleted the import-equiv-values branch November 15, 2019 03:46
@mightyiam mightyiam mentioned this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test that TypeScript rules that extend/replace ESLint rules have values exactly same as in Standard
1 participant