Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get eslint v9 to work #1734

Conversation

kristof-mattei
Copy link

@kristof-mattei kristof-mattei commented Aug 31, 2024

How?

eslint/use-at-your-own-risk exposes builtinRules, which is the same (albeit updated) ruleset of ESLint.

Since we only need the names of the rules, and not the actual implementation, we're fine using this. eslint-plugin-unicorn uses the same.

The changes below are the absolute minimum, to reduce diff & impact in migrating to eslint-config-love@v64.

Plugin changes:

I replaced eslint-plugin-import by eslint-plugin-import-x, and subsequently renamed all import/ prefixes to import-x/, as eslint-plugin-import doesn't support ESLint v9.

Rule changes:

@mightyiam
Copy link
Owner

I appreciate this, @kristof-mattei. Did you see discussion in #1734 ?

@kristof-mattei
Copy link
Author

@mightyiam the link you posted refers to this PR.

@mightyiam
Copy link
Owner

Woops. Sorry. I meant #1589

@kristof-mattei
Copy link
Author

Woops. Sorry. I meant #1589

That's awesome. Let me revert the import-x changes and give that a shot.

@mightyiam
Copy link
Owner

I expect a PR from renovate that bumps eslint-plugin-import. But I don't see one. Is there really a new version?

@kristof-mattei
Copy link
Author

I expect a PR from renovate that bumps eslint-plugin-import. But I don't see one. Is there really a new version?

#1737

@kristof-mattei
Copy link
Author

I expect a PR from renovate that bumps eslint-plugin-import. But I don't see one. Is there really a new version?

Okay, not gonna work as eslint-plugin-import still restricts eslint to be max v8.

At the moment all we can do is switch to eslint-plugin-import-x.

dangowans added a commit to cityssm/eslint-config-cityssm that referenced this pull request Oct 8, 2024
waiting for eslint-config-love to bring in new eslint-plugin-import that now supports v9

- mightyiam/eslint-config-love#1589
- mightyiam/eslint-config-love#1497
- mightyiam/eslint-config-love#1734
mightyiam pushed a commit that referenced this pull request Oct 12, 2024
@mightyiam mightyiam closed this in 018e202 Oct 12, 2024
eslint-config-love-release-bot bot pushed a commit that referenced this pull request Oct 12, 2024
## [85.0.0](v84.1.1...v85.0.0) (2024-10-12)

### ⚠ BREAKING CHANGES

* peerDep eslint ^9.0.0
* dep eslint-plugin-import ^2.31.0

### Features

* eslint v9 ([018e202](018e202)), closes [#1589](#1589) [#1734](#1734)
@mightyiam
Copy link
Owner

Thank you, @kristof-mattei .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants