-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get eslint v9 to work #1734
feat: get eslint v9 to work #1734
Conversation
…lint/use-at-your-own-risk
I appreciate this, @kristof-mattei. Did you see discussion in #1734 ? |
@mightyiam the link you posted refers to this PR. |
Woops. Sorry. I meant #1589 |
That's awesome. Let me revert the |
I expect a PR from renovate that bumps eslint-plugin-import. But I don't see one. Is there really a new version? |
|
Okay, not gonna work as At the moment all we can do is switch to |
waiting for eslint-config-love to bring in new eslint-plugin-import that now supports v9 - mightyiam/eslint-config-love#1589 - mightyiam/eslint-config-love#1497 - mightyiam/eslint-config-love#1734
Thank you, @kristof-mattei . |
How?
eslint/use-at-your-own-risk
exposesbuiltinRules
, which is the same (albeit updated) ruleset of ESLint.Since we only need the names of the rules, and not the actual implementation, we're fine using this.
eslint-plugin-unicorn
uses the same.The changes below are the absolute minimum, to reduce diff & impact in migrating to
eslint-config-love@v64
.Plugin changes:
I replaced
eslint-plugin-import
byeslint-plugin-import-x
, and subsequently renamed allimport/
prefixes toimport-x/
, aseslint-plugin-import
doesn't support ESLint v9.Rule changes:
no-new-symbol
is deprecated, replaced byno-new-native-nonconstructor
.line-comment-position
,multiline-comment-style
are no longer part of ESLint, and thus are no longer ignored as part of_rules_to_consider.ts
.import-x/prefer-default-export
popped up as part of theeslint-plugin-import
toeslint-plugin-import-x
migration. In order to minimize the migration cost, I've added it to_rules_to_consider.ts
instead of enabling it.