[TACKLE-114] Optimize Create/Update modals and reduce duplicate code #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 54.82% 54.61% -0.21%
==========================================
Files 169 155 -14
Lines 3969 3876 -93
Branches 778 790 +12
==========================================
- Hits 2176 2117 -59
+ Misses 1789 1755 -34
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
carlosthe19916
changed the title
# Conflicts: # public/locales/en/translation.json # public/locales/es/translation.json
# Conflicts: # src/pages/application-inventory/application-inventory.tsx # src/pages/application-inventory/application-list/components/new-application-modal/index.ts # src/pages/application-inventory/application-list/components/new-application-modal/new-application-modal.tsx # src/pages/application-inventory/application-list/components/update-application-modal/index.ts # src/pages/application-inventory/application-list/components/update-application-modal/update-application-modal.tsx
# Conflicts: # public/locales/en/translation.json # public/locales/es/translation.json # src/pages/application-inventory/application-list/application-list.tsx # src/shared/hooks/index.ts
# Conflicts: # public/locales/en/translation.json # public/locales/es/translation.json # src/pages/application-inventory/application-list/application-list.tsx # src/shared/hooks/index.ts # src/shared/hooks/useEntityModal/useEntityModal.test.tsx # src/shared/hooks/useEntityModal/useEntityModal.ts
# Conflicts: # src/pages/controls/business-services/business-services.tsx # src/pages/controls/stakeholder-groups/stakeholder-groups.tsx # src/pages/controls/stakeholders/stakeholders.tsx # src/pages/controls/tags/tags.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #108