Skip to content

Conversation

@carlosthe19916
Copy link
Contributor

@carlosthe19916 carlosthe19916 commented Sep 8, 2021

Changes in .github/workflows/ci-actions.yml

Changes in .github/workflows/container-images.yml

As a result of moving the creation of container images from .github/workflows/ci-actions.yml to .github/workflows/container-images.yml we won't see the skipped builds anymore.

About Chrome and Firefox tests

Both tests remain the same and the current tests will run against Firefox and Chrome. https://github.com/konveyor/tackle-ui/pull/241/files#diff-01e3594e03f5a2ed6326e7cad221efe59485466e940ef5876f68f99a578ec3dcR40

BEFORE:
Screenshot from 2021-09-08 12-02-46

AFTER (without skipped builds)
Screenshot from 2021-09-08 12-02-17

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Thanks for your contribution!
Every commit will generate a new build at https://github.com/carlosthe19916/tackle-ui/actions/workflows/pr-build-container-images.yml?query=branch%3AenhanceGHActions and once the build finishes you should be able to use the container image ghcr.io/carlosthe19916/tackle-ui/tackle-ui:enhanceGHActions
To see the full set of container images generated visit https://github.com/carlosthe19916/tackle-ui/packages

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #241 (f9ed34f) into main (434c776) will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   55.86%   55.43%   -0.43%     
==========================================
  Files         170      170              
  Lines        3990     3990              
  Branches      798      798              
==========================================
- Hits         2229     2212      -17     
- Misses       1757     1774      +17     
  Partials        4        4              
Flag Coverage Δ
e2etests 63.37% <ø> (-0.83%) ⬇️
unitests 27.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/store/confirmDialog/reducer.ts 53.33% <0.00%> (-40.01%) ⬇️
src/pages/controls/stakeholders/stakeholders.tsx 60.95% <0.00%> (-9.53%) ⬇️
src/api/rest.tsx 66.78% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434c776...f9ed34f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant