Skip to content

32 bit mesh support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edumlauer wants to merge 3 commits into
base: master
Choose a base branch
from
Open

32 bit mesh support #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
642c73c
Add support for meshes with more vertices than 65534
edumlauer Oct 22, 2018
2672f3c
Add warning about index format support
edumlauer Oct 22, 2018
4d7ee23
Update Unity package
edumlauer Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions Assets/WireframeRenderer/Scripts/WireframeRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,20 +215,21 @@ private void OnDisable()

Mesh GetProcessedMesh(Mesh mesh)
{
var maximumNumberOfVertices = 65534; //Since unity uses a 16-bit indices, not sure if this is still the case. http://answers.unity3d.com/questions/255405/vertex-limit.html
var maximumNumberOfVertices16Bit = 65534; //16-bit indices limit
var meshTriangles = mesh.triangles;
var meshVertices = mesh.vertices;
var meshNormals = mesh.normals;
var boneWeights = mesh.boneWeights;

var numberOfVerticesRequiredForTheProcessedMesh = meshTriangles.Length;
if (numberOfVerticesRequiredForTheProcessedMesh > maximumNumberOfVertices)
{
Debug.LogError("Wireframe renderer can't safely create the processed mesh it needs because the resulting number of vertices would surpass unity vertex limit!");
return null;
}

var processedMesh = new Mesh();
var processedMesh = new Mesh();

var numberOfVerticesRequiredForTheProcessedMesh = meshTriangles.Length;
if (numberOfVerticesRequiredForTheProcessedMesh > maximumNumberOfVertices16Bit)
{
// Change mesh to 32-bit index format to support more vertices
// Might not work on all platforms, for more info check: https://docs.unity3d.com/ScriptReference/Mesh-indexFormat.html
processedMesh.indexFormat = UnityEngine.Rendering.IndexFormat.UInt32;
}

var processedVertices = new Vector3[numberOfVerticesRequiredForTheProcessedMesh];
var processedUVs = new Vector2[numberOfVerticesRequiredForTheProcessedMesh];
Expand Down
Binary file modified packages/UnityWireframeRenderer.unitypackage
View file
Open in desktop
Binary file not shown.