[DNM] Fastbootification #104
Conversation
|
|
||
| //FASTBOOT-TODO: Exposing L here is a problem | ||
| L: Ember.computed('window.L', function(){ | ||
| if(L){ |
There was a problem hiding this comment.
I don't see how this computed property would help.
As I understand it, this CP returns undefined if L is undefined.
Isn't that exactly the same as doing L: L in the object definition?
Also, depending on window.L doesn't make a difference. Ember will try to look up a window object in the BaseLayer context.
There was a problem hiding this comment.
The Fastboot server throws because L is undefined... but using a CP seems to work around this. Agreed that it's a little O_o, but I can say it works.
| @@ -1,7 +1,7 @@ | |||
| /* global L */ | |||
|
|
|||
| export function initialize(/* container, application */) { | |||
| L.Icon.Default.imagePath = '/assets/images/'; | |||
| //L.Icon.Default.imagePath = '/assets/images/'; | |||
There was a problem hiding this comment.
Yes - I'm just not clear on where to add it.
The issue I ran into with this may be unique to loading ember-leaflet into an engine, and then loading that engine into an Ember App.
As you can see, I moved this initializer into /browser and combined with fastboot-filter-initializers, it should not be executed in node.
This was the case when I added ember-leaflet into the fastboot-ed Ember app, but once I added it to the Engine, I started to get errors on this line from Node.
|
Also, I don't exactly see how this PR is stopping |
|
From what I can tell, all |
|
Closing in lieu of #110 |
This is a first swipe at making this addon compatible with fastboot. I'm not confident this is ready to merge yet - details below...
I basically followed the Fastboot Addon Author Guide, and managed to get:
a)
ember fastboot --serve-assetsto run w/o errors related to L being undefined.b) A simple example map works once the page is loaded in the browser.
My need was a demo showing Fastboot + Ember Engines, so I can say that this does work, but various Engine related hacks were needed in both the Engine Addon that was consuming this
ember-leaflet, and the Ember App hosting the Engine.Caveats
I will check into both cases next week, but wanted to get this up for others to check out over the weekend if they are so inclined.